Skip to content

SCANGRADLE-376 Fix gradle9 GH Job on Peachee #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asya-vorobeva wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

SCANGRADLE-376 Fix gradle9 GH Job on Peachee #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/sonarqube/gradle/JavaCompilerUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ private JavaCompilerUtils() {

public static Optional<JavaCompilerConfiguration> extractJavaCompilerConfigurationFromCompileTasks(Project project) {
TaskCollection<JavaCompile> javaCompileTaskCollection = project.getTasks().withType(JavaCompile.class);
if (javaCompileTaskCollection.isEmpty()) {
List<JavaCompile> javaCompileTaskList = new ArrayList<>(javaCompileTaskCollection);
if (javaCompileTaskList.isEmpty()) {
Comment on lines +45 to +46
Copy link
Contributor

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am little skeptical of this solution because of bad past experiences with copying, and underlying iteration, over lazy collection provided by Gradle but let's give it a try. Worst case, it behaves exactly the same as before.

return Optional.empty();
}
List<JavaCompile> javaCompileTaskList = new ArrayList<>(javaCompileTaskCollection);
List<JavaCompilerConfiguration> jdkHomesUsedByCompileTasks = javaCompileTaskList.stream()
.map(JavaCompilerUtils::extractConfiguration)
.collect(Collectors.toList());
Expand Down
Loading