SCANGRADLE-376 Fix gradle9 GH Job on Peachee#445
SCANGRADLE-376 Fix gradle9 GH Job on Peachee#445asya-vorobeva wants to merge 1 commit intomasterfrom
Conversation
|
|
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
dorian-burihabwa-sonarsource
force-pushed
the
asya/fix-concurrent-modification-exception
branch
from
e03b83a to
5a8595a
Compare
dorian-burihabwa-sonarsource
force-pushed
the
asya/fix-concurrent-modification-exception
branch
from
5a8595a to
6bfe0b8
Compare
|
|
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
dorian-burihabwa-sonarsource
changed the title
| List<JavaCompile> javaCompileTaskList = new ArrayList<>(javaCompileTaskCollection); | ||
| if (javaCompileTaskList.isEmpty()) { |
There was a problem hiding this comment.
I am little skeptical of this solution because of bad past experiences with copying, and underlying iteration, over lazy collection provided by Gradle but let's give it a try. Worst case, it behaves exactly the same as before.
dorian-burihabwa-sonarsource
force-pushed
the
asya/fix-concurrent-modification-exception
branch
from
6bfe0b8 to
f420099
Compare
|
![sonar-review-alpha[bot]](https://avatars.githubusercontent.com/in/3025063?s=60&v=4){kind=small}
There was a problem hiding this comment.
Conclusion: Clean, targeted fix. Snapshotting the TaskCollection into an ArrayList before any operations on it is the correct way to avoid ConcurrentModificationException in Gradle 9, and moving the snapshot creation before the isEmpty() check ensures even that first call operates on the stable copy.
2 participants
Fix ConcurrentModificationException in JavaCompilerUtils.