[PWGLF] Table producer for photonDe correlation study#15509
Draft
arvindkhuntia wants to merge 8 commits intoAliceO2Group:masterfrom
Draft
[PWGLF] Table producer for photonDe correlation study#15509arvindkhuntia wants to merge 8 commits intoAliceO2Group:masterfrom
arvindkhuntia wants to merge 8 commits intoAliceO2Group:masterfrom
Conversation
arvindkhuntia
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
lhusova,
maciacco,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692 and
smaff92
as code owners
Please consider the following formatting changes to AliceO2Group#15509
Please consider the following formatting changes to AliceO2Group#15509
Collaborator
|
Error while checking build/O2Physics/o2 for 9dd013d at 2026-03-24 20:10: Full log here. |
Collaborator
|
@arvindkhuntia How did you test your changes? They don't compile. |
vkucera
reviewed
Mar 24, 2026
| #include "Framework/HistogramRegistry.h" | ||
| #include "Framework/runDataProcessing.h" | ||
|
|
||
| #include <TLorentzVector.h> |
| #include <TLorentzVector.h> | ||
| #include <TVector3.h> | ||
|
|
||
| #include <iostream> |
| using namespace o2::framework; | ||
| using namespace o2::framework::expressions; | ||
|
|
||
| struct PhotonDeuteronCorrelation { |
Collaborator
There was a problem hiding this comment.
Why is it different from the file name?
Comment on lines
+117
to
+118
| o2physics_add_dpl_workflow(photon-deuteron-corr | ||
| SOURCES photonDeuteron.cxx |
Collaborator
There was a problem hiding this comment.
Why do these names consist of different words?
Comment on lines
+62
to
+65
| // Particle masses (in GeV/c²) | ||
| static constexpr float massProton = o2::constants::physics::MassProton; | ||
| static constexpr float massNeutron = o2::constants::physics::MassNeutron; | ||
| static constexpr float massDeuteron = o2::constants::physics::MassDeuteron; |
Collaborator
There was a problem hiding this comment.
Useless. Do not hide the use of common constants.
Comment on lines
+179
to
+189
| float getDeltaPhi(float phi1, float phi2) | ||
| { | ||
| float dphi = phi1 - phi2; | ||
| if (dphi > 1.5 * M_PI) { | ||
| dphi -= 2.0 * M_PI; | ||
| } | ||
| if (dphi < -0.5 * M_PI) { | ||
| dphi += 2.0 * M_PI; | ||
| } | ||
| return dphi; | ||
| } |
Collaborator
There was a problem hiding this comment.
Why are you reinventing the wheel?
Comment on lines
+294
to
+299
| TLorentzVector photonVec, deuteronVec; | ||
| photonVec.SetPtEtaPhiM(photon.pt(), photon.eta(), photon.phi(), 0.0); // Photon-mass = 0 | ||
| deuteronVec.SetPtEtaPhiM(deuteron.pt(), deuteron.eta(), deuteron.phi(), massDeuteron); // Deuteron-mass | ||
|
|
||
| TLorentzVector combinedVec = photonVec + deuteronVec; | ||
| float invMass = combinedVec.M(); |
Collaborator
There was a problem hiding this comment.
You don't need TLorentzVector for these simple calculations. Use RecoDecay methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.