feat: add keyword subcategories to Ruby highlights#275
Open
infinityrobot wants to merge 2 commits intozed-extensions:mainfrom
Open
feat: add keyword subcategories to Ruby highlights#275infinityrobot wants to merge 2 commits intozed-extensions:mainfrom
infinityrobot wants to merge 2 commits intozed-extensions:mainfrom
Conversation
Split the monolithic `@keyword` capture into semantic subcategories, enabling themes to differentiate between definition, conditional, loop, flow control, and exception keywords. New captures: - `@keyword.function` — class, def, module - `@keyword.control.conditional` — if, elsif, else, unless, case, when, then - `@keyword.control.repeat` — while, until, for, do - `@keyword.control.return` — return, next, break, retry, yield - `@keyword.exception` — begin, ensure, rescue (+ existing raise/fail/catch/throw) - `@keyword` — alias, and, end, in, or (general/structural) This is fully backward compatible — themes that only define `keyword` will continue to work via Zed's fallback resolution (e.g. `keyword.control.return` → `keyword.control` → `keyword`). Follows the precedent set by the SCSS extension which already uses `keyword.control.conditional`, `keyword.control.return`, `keyword.function`, and `keyword.repeat`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
We require contributors to sign our Contributor License Agreement, and we don't have @infinityrobot on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the monolithic
@keywordcapture in Ruby'shighlights.scminto semantic subcategories, enabling themes to style different keyword types independently.New captures
@keyword.functionclass,def,module@keyword.control.conditionalif,elsif,else,unless,case,when,then@keyword.control.repeatwhile,until,for,do@keyword.control.returnreturn,next,break,retry,yield@keyword.exceptionbegin,ensure,rescue(alongside existingraise/fail/catch/throw)@keywordalias,and,end,in,or(general/structural)Backward compatibility
Fully backward compatible — themes that only define
keywordwill continue to work via Zed's fallback resolution (e.g.keyword.control.return→keyword.control→keyword).Precedent
Follows the pattern already established by the SCSS extension, which uses
keyword.control.conditional,keyword.control.return,keyword.function, andkeyword.repeat.Motivation
Currently it's impossible to visually distinguish
return/yieldfromdef/endorif/unlessin Ruby. This is a common theme customisation need — other editors (VS Code, Sublime) support this level of granularity. This change brings Ruby in line with other Zed language extensions that already provide keyword subcategories.