Skip to content

fix(underscore-redirects): preserve trailing slash#15979

Open
alexanderniebuhr wants to merge 4 commits intomainfrom
flue/fix-13165
Open

fix(underscore-redirects): preserve trailing slash#15979
alexanderniebuhr wants to merge 4 commits intomainfrom
flue/fix-13165

Conversation

@alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Mar 18, 2026

Changes

Testing

  • existing tests
  • should we make the tests for advanced, currently they only test if the length is equal?
  • how should we make the test, snapshot match?

Docs

  • internal, so I don't think needed

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: 5471b12

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexanderniebuhr alexanderniebuhr marked this pull request as ready for review March 18, 2026 08:05
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we really should create some tests, wether units or integration, doesn't matter

Signed-off-by: Alexander Niebuhr <45965090+alexanderniebuhr@users.noreply.github.com>
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 18, 2026
Signed-off-by: Alexander Niebuhr <45965090+alexanderniebuhr@users.noreply.github.com>
@alexanderniebuhr
Copy link
Member Author

I'v fixed the changeset and added the test case in Cloudflare specificly since that was what was reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Cloudflare adapter strips the trailing slash, causing the redirect to become a 404

4 participants