chore: revert default for :pending_connection_errors to true and update related docs and specs#572
Open
chore: revert default for :pending_connection_errors to true and update related docs and specs#572
Conversation
route
force-pushed
the
revert-pending_connection_errors
branch
from
90c185f to
fa85cb9
Compare
…te related docs and specs
route
force-pushed
the
revert-pending_connection_errors
branch
2 times, most recently
from
46fe161 to
32c2496
Compare
That was a sinatra disposition header issue, not chrome that was opening pdf extension. The header was not set because public folder was handled by rack static and file was returned to chrome without disposition header making chrome extension to intercept pdf request.
route
force-pushed
the
revert-pending_connection_errors
branch
from
32c2496 to
d53ff22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.