Use array instead of List for ROS message types#165
Open
jacobperron wants to merge 8 commits intodashingfrom
Open
Use array instead of List for ROS message types#165jacobperron wants to merge 8 commits intodashingfrom
jacobperron wants to merge 8 commits intodashingfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #151.
Switching from
java.util.Listto arrays significantly improves performance when converting from C to Java types.Though, for some applications it is still nice to use a list so I've added a convenience methods for getting and setting the value as a
List(df08714). I've still opted for having the default getter method return an array type to encourage users to use arrays, since converting to aListis not very efficient.