[_cffi_backend] Improve CField, CType, _CDataBase, buffer#15530
Draft
mildsunrise wants to merge 4 commits intopython:mainfrom
Draft
[_cffi_backend] Improve CField, CType, _CDataBase, buffer#15530mildsunrise wants to merge 4 commits intopython:mainfrom
mildsunrise wants to merge 4 commits intopython:mainfrom
Conversation
the implementation really doesn't allow other objects being passed, and I see other stubs doing this, so I presume it's okay?
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
|
LGTM, I'll merge this when you undraft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these were verified against implementation code. the docs are not very precise on some of these things, but I think it's clear all this is intended to be public facing API. CType in particular will be documented better as part of python-cffi/cffi#231.
draft because I still need to resolve the style issues (so far I can only see (1) replacing
Optionalwith| None, and (2) importingSelffrom _typing_extensions).I also need to see if Python/typeshed allows structural typing (because available CType fields vary depending on the value of
kind)