Open
Conversation
* Add `Final` * Add default values * Use `bool | Literal[0, 1]` for boolean params (instead of `int`) * Annotate known parts (Source: https://github.com/mhammond/pywin32/tree/b311/com/win32com)
donbarbos
commented
Mar 19, 2026
Comment on lines
+12
to
13
| @type_check_only | ||
| class _DispatchCreateClass(Protocol[_T_co]): |
Contributor
Author
There was a problem hiding this comment.
cc @brianschubert I didn’t find any occurrences of this name in the source code (via grep), so I thought this case might also be interesting for your stubtest patch.
Collaborator
There was a problem hiding this comment.
Looks like this is covered by an allowlist entry, which is why it hasn't been flagged yet:
typeshed/stubs/pywin32/@tests/stubtest_allowlist_win32.txt
Lines 14 to 15 in 50ec910
Maybe you can refine that while we're here?
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalbool | Literal[0, 1]for boolean params (instead ofint)(Source: https://github.com/mhammond/pywin32/tree/b311/com/win32com)