[mypyc] Add missing header includes in lib-rt files#21046
Merged
p-sawicki merged 3 commits intopython:masterfrom Mar 19, 2026
Merged
[mypyc] Add missing header includes in lib-rt files#21046p-sawicki merged 3 commits intopython:masterfrom
p-sawicki merged 3 commits intopython:masterfrom
Conversation
JukkaL
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These headers use objects from
stdbool.handmypyc_util.hwithout including them so they currently rely on the dependencies being included somewhere earlier in the compiled .c file. However compiling juststringwriter_extra_ops.corbyteswriter_extra_ops.cwithMYPYC_EXPERIMENTALdefined results in errors.Added a test to compile every .c file in mypyc/lib-rt individually with and without
MYPYC_EXPERIMENTALdefined to catch these issues in the future. ChatGPT wrote the test and I have verified that removing a necessary header include fails it.