Conversation
webknjaz
left a comment
There was a problem hiding this comment.
Looks great at glance! Does it need an entire hour to complete though? If not, I'd make the timeout smaller.
|
I just copied the |
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 9da3ed3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
So it took 19m 28s with no cache. But the cache is not working yet. |
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit d77a339 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
!buildbot Emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 4276a51 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot Emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 4276a51 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 1520ee8 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Emscripten is (currently) tier 3, so should we allow PRs to be merged when this fails? Although in practice, people generally don't like merging red PRs, which is good. And testing here on GHA can help later promote to a higher tier, when we wouldn't allow failures. |
Is it required to run sequentially? Although it can help to have some sequential CI, and there's slower jobs than this one so it won't be the bottleneck. |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
We don't have any threads or process support so I think so. |
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 9d545d1 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Alright, let's set the timeout to 25-30 minutes — this will help catch problems early. We just need to cover the cacheless run, plus have some margin for networking + minor flakiness. Otherwise, situations with something getting stuck for 40min+ would waste CI resources.. |
|
Well we have: Since most other CI jobs seem to have |
Time:
By comparison, the build bot took 32m 8s with cache. I guess the github action runners are quite a bit faster than the instance running the build bot.