Skip to content

gh-146197: Add Emscripten to CI#146198

Open
hoodmane wants to merge 10 commits intopython:mainfrom
hoodmane:emscripten-ci
Open

gh-146197: Add Emscripten to CI#146198
hoodmane wants to merge 10 commits intopython:mainfrom
hoodmane:emscripten-ci

Conversation

@hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Mar 20, 2026

Time:

  • 19m 28s without cache
  • 17m 8s with cache

By comparison, the build bot took 32m 8s with cache. I guess the github action runners are quite a bit faster than the instance running the build bot.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great at glance! Does it need an entire hour to complete though? If not, I'd make the timeout smaller.

@hoodmane
Copy link
Contributor Author

I just copied the timeout-minutes: 60 from reusable-wasi which doesn't need 60 minutes either.

@hoodmane
Copy link
Contributor Author

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 9da3ed3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@hoodmane
Copy link
Contributor Author

So it took 19m 28s with no cache. But the cache is not working yet.

@hoodmane
Copy link
Contributor Author

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit d77a339 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hoodmane
Copy link
Contributor Author

!buildbot Emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 4276a51 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge

The command will test the builders whose names match following regular expression: Emscripten

The builders matched are:

  • WASM Emscripten PR

@hoodmane
Copy link
Contributor Author

!buildbot Emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 4276a51 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge

The command will test the builders whose names match following regular expression: Emscripten

The builders matched are:

  • WASM Emscripten PR

@hoodmane
Copy link
Contributor Author

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 1520ee8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@hoodmane hoodmane added the needs backport to 3.14 bugs and security fixes label Mar 20, 2026
@hoodmane hoodmane requested a review from freakboy3742 March 20, 2026 11:46
@hugovk
Copy link
Member

hugovk commented Mar 20, 2026

Emscripten is (currently) tier 3, so should we allow PRs to be merged when this fails?

Although in practice, people generally don't like merging red PRs, which is good. And testing here on GHA can help later promote to a higher tier, when we wouldn't allow failures.

@hugovk
Copy link
Member

hugovk commented Mar 20, 2026

0:00:00 load avg: 0.10 Run 501 tests sequentially in a single process

Is it required to run sequentially?

Although it can help to have some sequential CI, and there's slower jobs than this one so it won't be the bottleneck.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hoodmane
Copy link
Contributor Author

Is it required to run sequentially?

We don't have any threads or process support so I think so.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hoodmane
Copy link
Contributor Author

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 9d545d1 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146198%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@webknjaz
Copy link
Member

Alright, let's set the timeout to 25-30 minutes — this will help catch problems early. We just need to cover the cacheless run, plus have some margin for networking + minor flakiness. Otherwise, situations with something getting stuck for 40min+ would waste CI resources..

@hoodmane
Copy link
Contributor Author

hoodmane commented Mar 20, 2026

Well we have:

  1 job  with timeout-minutes: 30
  5 jobs with timeout-minutes: 5
  8 jobs with timeout-minutes: 10
 26 jobs with timeout-minutes: 60

Since most other CI jobs seem to have timeout-minutes: 60 I'd prefer to just keep the setting here as for the rest and then lowering these timeouts can be dealt with systematically as a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants