gh-146059: Call fast_save_leave() in pickle save_frozenset()#146173
gh-146059: Call fast_save_leave() in pickle save_frozenset()#146173vstinner wants to merge 3 commits intopython:mainfrom
Conversation
vstinner
added
needs backport to 3.13
Lib/test/pickletester.py
Outdated
| buf = io.BytesIO() | ||
| pickler = self.pickler(buf, protocol=proto) | ||
| # Enable fast mode (disables memo, enables cycle detection) | ||
| pickler.fast = 1 |
There was a problem hiding this comment.
Would it be also worth it to test non-fast mode? The bug only triggers in fast mode.
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please add also tests for list, set, dict, tuple and frozendict.
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Also, this mechanism is used to guard against deeply nested structures, so it would be worth to test deeply nested structures.
There are sets of tests for recursive structures. We can use similar tests for limited but deep recursion.
Lib/test/pickletester.py
Outdated
| # Enable fast mode (disables memo, enables cycle detection) | ||
| pickler.fast = 1 | ||
|
|
||
| if tested_type == frozenset: |
There was a problem hiding this comment.
More Pythonic way would be to make tested_type and data parameters and call the function with different arguments.
|
@serhiy-storchaka: Please review the updated PR. Is it what you expected?
I added deep_nested_struct() tests for the 6 types.
Good idea, I rewrote tests like that. |
2 participants
Fatal Python errorwhen using_picklewith manyfrozensetobjects #146059