Open
Conversation
… False or `dev_tools_validate_callbacks` is False (cherry picked from commit 077a3e7)
…erns for callbacks, great reduction in overhead
ndrezn
reviewed
Mar 19, 2026
| if store == "disabled": | ||
| print(f"Average time with store disabled: {avg_time:.2f} ms") | ||
| assert ( | ||
| avg_time < 100 |
Member
There was a problem hiding this comment.
Having a fixed time test could lead to flakiness if our runner types change or have downtime/performance issues. @T4rk1n do you have any ideas on how to add performance regression testing for this change?
Contributor
There was a problem hiding this comment.
Not sure there are better ways, the threshold should reflect what we think is acceptable.
Contributor
Author
There was a problem hiding this comment.
If you want to benchmark outside of this, on specific devices, it might be worth running it on something like lambdatest, browser stack or something similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3661
adjustments for computeGraphs to not have validation when in debug is False or
dev_tools_validate_callbacksis False