utils: replace chardet with charset-normalizer#775
Closed
CyberTailor wants to merge 3 commits intopkgcore:masterfrom
Closed
utils: replace chardet with charset-normalizer#775CyberTailor wants to merge 3 commits intopkgcore:masterfrom
CyberTailor wants to merge 3 commits intopkgcore:masterfrom
Conversation
Replace a 'utf_16_be'-decodable byte string with another, which is non-decodable. Signed-off-by: Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
Replace 'Big5'-decodable byte string with another, which is non-decodable. Signed-off-by: Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
Also replaces our custom heuristics with charset_normalizer.is_binary(). Signed-off-by: Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
arthurzam
approved these changes
Mar 22, 2026
Member
arthurzam
left a comment
arthurzam
left a comment
There was a problem hiding this comment.
I see that charset-normalizer has no python lib dependencies, which is nice and what I prefer.
Looks good, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chardet 7.0 has been completely rewritten using AI coding agents, and now related pkgcheck's tests fail. It's unlikely that chardet v7 will be packaged in Gentoo, so it makes no sense to make pkgcheck compatible with it. It also doesn't really make sense to pin to
chardet<7, as it won't receive updates. Switching to another library would be fine.I think we can also remove most of our custom "binary or not" heuristics,
charset_normalizer.is_binaryshould be good enough.Another reason to switch from chardet: