Switch to upstreamed VssStore from lightning-persister#837
Draft
tnull wants to merge 1 commit intolightningdevkit:mainfrom
Draft
Switch to upstreamed VssStore from lightning-persister#837tnull wants to merge 1 commit intolightningdevkit:mainfrom
VssStore from lightning-persister#837tnull wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Hi! This PR is now in draft status. |
tnull
force-pushed
the
2026-03-switch-to-upstreamed-vss
branch
from
c2f7e23 to
00b59ac
Compare
Delete the local `VssStore`/`VssStoreBuilder` implementation and consume the upstreamed version from `lightning-persister` instead. The `Builder` now derives the VSS `Xpriv` inline before passing it to the upstream `VssStoreBuilder`, which no longer takes `NodeEntropy` directly. Also switch all `vss_client` imports to the re-export from `lightning_persister::vss_client` and drop the direct `vss-client-ng` dependency to avoid version mismatches. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
tnull
force-pushed
the
2026-03-switch-to-upstreamed-vss
branch
from
00b59ac to
b7099e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on lightningdevkit/rust-lightning#4323
Delete the local
VssStore/VssStoreBuilderimplementation and consume the upstreamed version fromlightning-persisterinstead. TheBuildernow derives the VSSXprivinline before passing it to the upstreamVssStoreBuilder, which no longer takesNodeEntropydirectly.Also switch all
vss_clientimports to the re-export fromlightning_persister::vss_clientand drop the directvss-client-ngdependency to avoid version mismatches.Co-Authored-By: HAL 9000