feat(pipeline): use batchSize as selector page size#301
Merged
Conversation
ddeboer
changed the title
- Remove separate pageSize option from SparqlItemSelector — batchSize is the single knob controlling both executor batch size and selector page size - Stage passes its batchSize to ItemSelector.select() - A LIMIT clause in the selector query overrides batchSize for endpoints with hard result limits - Priority: query LIMIT > stage batchSize > default of 10 - Document batchSize behaviour in the pipeline README
ddeboer
force-pushed
the
feat/selector-page-size-from-batch-size
branch
from
c812378 to
90e54b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pageSizeoption fromSparqlItemSelector—batchSizeis the single knob that controls both executor batch size and selector page sizeStagepasses itsbatchSizetoItemSelector.select(), so each paginated selector request fills exactly one executor batchLIMITclause in the selector query overridesbatchSize(for endpoints with hard result limits)LIMIT> stagebatchSize> default of 10pageSize: 1000frompipeline-void'sclassSelector()(the query already hasLIMIT 1000)batchSizebehaviour in the pipeline README, including its relation to selector pagination and queryLIMITFix #298