Skip to content

Reorganise tests#367

Merged
glesur merged 22 commits intodevelopfrom
reorganiseTests
Mar 26, 2026
Merged

Reorganise tests#367
glesur merged 22 commits intodevelopfrom
reorganiseTests

Conversation

@glesur
Copy link
Contributor

@glesur glesur commented Mar 19, 2026

  • separate tests of specific IO routines from physics tests (XDMF and restart dumps)
  • add all IO tests to github actions
  • add Sedov to the test suite.

svalat added a commit to svalat/idefix that referenced this pull request Mar 23, 2026
…way via testme.json + handle single variant defined in testme.json
@glesur glesur requested a review from Copilot March 24, 2026 07:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reorganizes the test suite by separating IO-focused tests (restart dumps, XDMF, Pydefix) from physics tests, and updates CI to run the expanded test matrix (including Sedov).

Changes:

  • Moved restart validation out of the OrszagTang3D physics test into a dedicated IO “dump” test.
  • Added new IO tests for XDMF output and Pydefix, and wired them into GitHub Actions.
  • Added Sedov blast wave to CI and adjusted some test tolerances/output cadence.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/MHD/OrszagTang3D/testme.py Removes restart validation from the physics regression test.
test/MHD/OrszagTang3D/setup.cpp Removes restart-analysis logic from OrszagTang3D setup.
test/MHD/LinearWaveTest/testme.py Adjusts tolerance for the linear wave test.
test/MHD/LinearWaveTest/idefix-entropy.ini Increases log cadence for the entropy variant.
test/IO/xdmf/testme.py Adds a new IO test driver intended to validate XDMF output.
test/IO/xdmf/setup.cpp Adds minimal setup to generate a representative MHD state for XDMF dumps.
test/IO/xdmf/idefix.ini Adds a config that enables XDMF + dump output for the new test.
test/IO/xdmf/definitions.hpp Adds build definitions for the new XDMF IO test.
test/IO/pydefix/testme.py Adds a new IO test covering Pydefix dump generation/regression.
test/IO/pydefix/python_requirements.txt Adjusts pybind11 minimum version and adds a comment.
test/IO/pydefix/idefix.ini Adjusts output cadence and enables dmp output for Pydefix test.
test/IO/dump/testme.py Adds a dedicated restart-dump IO test driver.
test/IO/dump/setup.cpp Adds restart validation analysis (moved from OrszagTang3D).
test/IO/dump/definitions.hpp Adds build definitions for the new dump IO test.
test/IO/dump/CMakeLists.txt Enables MHD property for the IO dump test target.
test/HD/SedovBlastWave/idefix.ini Removes XDMF output from Sedov and tweaks output formatting.
test/HD/SedovBlastWave/CMakeLists.txt Adds an MHD property line (in addition to HDF5).
src/setup.cpp Suppresses default Setup warning when built with Python enabled.
src/pydefix.cpp Marks some arrays as maybe_unused and prints Python runtime details at startup.
src/output/xdmf.cpp Adds maybe_unused annotations to avoid warnings in some build modes.
reference Updates submodule reference SHA.
CMakeLists.txt Adds stricter HDF5 parallel checks under MPI and adds Python3/pybind11 CMake path setup.
.github/workflows/idefix-ci-jobs.yml Adds Sedov + IO test job and includes LinearWaveTest in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

glesur and others added 3 commits March 24, 2026 13:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@glesur glesur merged commit 8171c32 into develop Mar 26, 2026
41 checks passed
@glesur glesur deleted the reorganiseTests branch March 26, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants