feat: add diagnostics_channel support for app initialization#7041
Open
DemianParkhomenko wants to merge 2 commits intoexpressjs:masterfrom
Open
feat: add diagnostics_channel support for app initialization#7041DemianParkhomenko wants to merge 2 commits intoexpressjs:masterfrom
DemianParkhomenko wants to merge 2 commits intoexpressjs:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for Node.js diagnostics_channel to Express, specifically implementing an express.initialization channel that publishes when an Express application is created. This allows instrumentation libraries (like OpenTelemetry) to hook into the app lifecycle before any requests are handled, enabling better observability and monitoring capabilities.
Changes:
- Added a new
lib/diagnostics.jsmodule that creates and exports theexpress.initializationdiagnostics channel - Modified
lib/express.jsto publish to the initialization channel afterapp.init()is called - Added comprehensive tests for the diagnostics channel functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/diagnostics.js | New module that creates the express.initialization diagnostics channel |
| lib/express.js | Imports diagnostics module and publishes initialization event when app is created |
| test/diagnostics-channel.js | Test suite verifying channel publishes correctly and handles no-subscriber case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes
express.initializationchannel when an Express app is created,allowing instrumentation libraries to attach middleware and hooks before
any request arrives.
Route-level tracing (start/end/error per request with matched route pattern)
will be implemented in the
routermodule usingTracingChannelAPI.Refs: #6353 https://github.com/pillarjs/router/pull/96/changes