eframe: Fix white flash when opening non-root viewports on Windows#7970
Open
gcailly wants to merge 1 commit intoemilk:mainfrom
Open
eframe: Fix white flash when opening non-root viewports on Windows#7970gcailly wants to merge 1 commit intoemilk:mainfrom
gcailly wants to merge 1 commit intoemilk:mainfrom
Conversation
The existing fix (PR emilk#3631) starts the root window hidden and shows it after the first frame is painted. However, deferred and immediate viewports created later are still visible immediately, causing a white flash before the first frame is rendered. This applies the same pattern to non-root viewports: create them with visible(false) and call window.set_visible(true) after the first frame has been painted and presented. Note: I am not a Rust programmer — this PR was developed with the help of Claude Code. Happy to address any feedback.
|
Preview available at https://egui-pr-preview.github.io/pr/7970-fixwindows-viewport-white-flash View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing fix (PR #3631) starts the root window hidden and shows it after the first frame is painted. However, deferred and immediate viewports created later are still visible immediately, causing a brief white flash before the first frame is rendered.
This PR applies the same pattern to non-root viewports:
visible(false)window.set_visible(true)after the first frame has been painted and presentedBoth the
glowandwgpubackends are covered.Before and after
Untitled.mp4
Test plan
multiple_viewportsexample on Windows 11EpiIntegration::post_rendering)Disclaimer: I am not a Rust programmer — this PR was developed with the help of Claude Code. Happy to address any feedback.