Skip to content

Add service credential rotation feature doc#585

Open
jochenehret wants to merge 4 commits intocloudfoundry:masterfrom
sap-contributions:multi-service-bindings
Open

Add service credential rotation feature doc#585
jochenehret wants to merge 4 commits intocloudfoundry:masterfrom
sap-contributions:multi-service-bindings

Conversation

@jochenehret
Copy link
Contributor

No description provided.

@stephanme stephanme requested a review from beyhan March 19, 2026 12:11
@stephanme
Copy link
Member

Invited @beyhan for review since he is an author of the rfc-0040-service-binding-rotation.

beyhan
beyhan previously approved these changes Mar 20, 2026
stephanme
stephanme previously approved these changes Mar 20, 2026
Copy link
Contributor

@anita-flegg anita-flegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have made these changes myself, but I can no longer push changes without forking.
I'm not sure whether this was a deliberate change, but was was certainly easier when I had full permissions.

@beyhan
Copy link
Member

beyhan commented Mar 24, 2026

I would have made these changes myself, but I can no longer push changes without forking. I'm not sure whether this was a deliberate change, but was was certainly easier when I had full permissions.

@anita-flegg We've activated branch protection rules by default, which means direct pushes to repositories aren't allowed anymore. When people even approver propose changes, they need to go through a pull request first. Since this particular PR is based on a fork, you won't be able to make direct changes to it. I'm not aware of any other permission changes. Please reach out to me via Slack if you have further question.

@jochenehret jochenehret dismissed stale reviews from stephanme and beyhan via e50f86f March 24, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants