TA-5049 add content-cli options to list staging variables#325
Draft
Patrick Vicinus (pvicinus) wants to merge 11 commits intomainfrom
Draft
Conversation
- Document --json as array of Pacman manifests per package
- Mock GET responses as { packageKey, variables }
- Remove unused FatalError import; format results.push
Includes-AI-Code: true
Made-with: Cursor
Use Pacman batch staging-variables API (by-package-keys) for config variables listStaging, with optional variableType filter. Document listStaging in the user guide like other variable listing commands—command-focused, without internal API details. Includes-AI-Code: true Made-with: Cursor
- Move listStagingVariables coverage to config-list-staging-variables.spec.ts - Align assertions with listVariables (post body, json export, errors) - Add withQueryString helper for mock URLs Includes-AI-Code: true Made-with: Cursor
Replace listStaging with --packageKeys on variables list; mutual exclusion with versioned options. Consolidate tests, update user guide, and set Commander defaults on variables list options (module.spec mirrors parsed shape). Pass variables list options through to ConfigCommandService without casts. Includes-AI-Code: true Made-with: Cursor
Drop the staging variable type filter from config variables list and the Pacman client call. Update config-commands.md: mutual exclusivity of modes, shared JSON manifest shape (version only for published), and clearer published vs unpublished documentation. Includes-AI-Code: true Made-with: Cursor
Patrick Vicinus (pvicinus)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds listing of unpublished (staging) package variables via
config variables list --packageKeys, backed by Pacman’s batch staging-variables API. Published variables stay on--keysByVersion/--keysByVersionFile. The two approaches are mutually exclusive (CLI validates and errors if combined or if neither is provided).Relevant links
Checklist
Summary
config variables list --packageKeys <key> …— staging variables; optional--jsonwrites a JSON array of{ packageKey, variables }per package.config variables list --keysByVersion …or--keysByVersionFile …— unchanged for published versions; JSON entries includeversion.Verify