update the beman.execution reference version#76
Merged
dietmarkuehl merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
dietmarkuehl
requested review from
bretbrownjr,
steve-downey and
wusatosi
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned beman.execution dependency revision used via CMake FetchContent to a newer upstream commit.
Changes:
- Update
FetchContent_Declare(execution)to use a newGIT_TAGcommit reference.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # FETCHCONTENT_SOURCE_DIR_EXECUTION ${CMAKE_SOURCE_DIR}/../execution | ||
| GIT_REPOSITORY https://github.com/bemanproject/execution | ||
| GIT_TAG 3650634 | ||
| GIT_TAG 09d5a5c |
There was a problem hiding this comment.
GIT_TAG is pinned to a short SHA (09d5a5c). Short SHAs can become ambiguous as the upstream repo grows, which can break FetchContent clones and also makes it harder to trace what version is being consumed. Prefer pinning to an immutable release tag (e.g., 0.2.0/v0.2.0 if available) or at least the full 40-character commit SHA, and ensure it corresponds to the 0.2.0 EXACT version expected below.
Suggested change
| GIT_TAG 09d5a5c | |
| GIT_TAG v0.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.