Hide inactive offerings from User type accounts#12865
Open
erikbocks wants to merge 3 commits intoapache:mainfrom
Open
Hide inactive offerings from User type accounts#12865erikbocks wants to merge 3 commits intoapache:mainfrom
erikbocks wants to merge 3 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12865 +/- ##
============================================
- Coverage 18.02% 18.02% -0.01%
- Complexity 16450 16451 +1
============================================
Files 5968 5968
Lines 537086 537090 +4
Branches 65961 65962 +1
============================================
- Hits 96819 96818 -1
- Misses 429347 429350 +3
- Partials 10920 10922 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the UI “Compute Offerings” listing configuration so User accounts don’t see inactive offerings and don’t get a state filter dropdown, while Admin/DomainAdmin behavior remains unchanged.
Changes:
- For
computeoffering, default API params now forcestate=Activefor non-admin roles. computeofferingfilter options are now role-aware (state filter hidden for Users).computeofferingtable columns were adjusted (GPU column removed).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
erikbocks
force-pushed
the
change-inactive-offerings-view-normal-user
branch
from
b01ae39 to
9055136
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the compute offerings tab behavior to prevent the listing of inactive offerings to User type accounts.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
Logged in as the ROOT admin, I validated that the compute offerings' listing displayed the filter button, and allowed the listing of
ActiveandInactiveofferings. Then, I logged in with aUsertype account, and validated that the state filter button was hidden, and onlyActiveofferings were listed.