Skill: use forkScoped + Fiber.join for lazy init#18282
Draft
kitlangton wants to merge 7 commits intodevfrom
Draft
Skill: use forkScoped + Fiber.join for lazy init#18282kitlangton wants to merge 7 commits intodevfrom
kitlangton wants to merge 7 commits intodevfrom
Conversation
Constrain BusEvent.define to ZodObject instead of ZodType so TS knows
event properties are always a record. Type GlobalBus payload as
{ type: string; properties: Record<string, unknown> } instead of any.
Refactor watcher test to use Bus.subscribe instead of raw GlobalBus
listener, removing hand-rolled event types and unnecessary casts.
…operations Convert add/scan/load from async functions wrapped in Effect.promise to proper Effect.fn generators using AppFileSystem.Service for isDir, glob, and up operations. This eliminates the nested Effect.runPromise call for discovery.pull and enables concurrent skill file processing.
# ------------------------ >8 ------------------------ # Do not modify or remove the line above. # Everything below it will be ignored. # # Conflicts: # packages/opencode/src/skill/skill.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure()/Effect.promiselazy-init pattern in Skill withforkScoped+Fiber.joinCachetype,State.taskfield, andcreatehelper functionTest plan
bun run typecheckpassesbun run testpasses/skillinvocation