Skip to content

fix(app): terminal rename from context menu#18263

Open
neriousy wants to merge 4 commits intoanomalyco:devfrom
neriousy:fix/terminal-rename
Open

fix(app): terminal rename from context menu#18263
neriousy wants to merge 4 commits intoanomalyco:devfrom
neriousy:fix/terminal-rename

Conversation

@neriousy
Copy link
Contributor

@neriousy neriousy commented Mar 19, 2026

Issue for this PR

Closes #18248

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Currently "rename" on from the context menu does not work

here's what roughly is going on

  1. menu item is selected
  2. input mounts
  3. effect tries to focus the input
  4. dropdown close finishes
  5. dropdown steals focus back for its own restore logic
  6. the input either blurs immediately or never becomes the stable focused element

This PR fixes it & adds a regression test

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

First, right click on terminal, then click "Rename."

Screenshots / recordings

2026-03-19.19-32-10.mp4

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@neriousy neriousy marked this pull request as ready for review March 19, 2026 18:32
@neriousy neriousy requested a review from adamdotdevin as a code owner March 19, 2026 18:32
@neriousy
Copy link
Contributor Author

test seems to be failing cause of upstream (not caused by this pr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop UI Freezes on trying to rename Terminal window

1 participant