Skip to content

build: add @bazel/ibazel as a dev dependency#32808

Open
hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs:add-ibazel
Open

build: add @bazel/ibazel as a dev dependency#32808
hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs:add-ibazel

Conversation

@hawkgs
Copy link
Member

@hawkgs hawkgs commented Mar 20, 2026

Add @bazel/ibazel as a dev dependency to the workspace root.

Can be handy for test-driven development and/or testing.

Add `@bazel/ibazel` as a dev dependency to the workspace root.
@hawkgs hawkgs requested review from alan-agius4 and clydin March 20, 2026 14:59
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 20, 2026
@hawkgs
Copy link
Member Author

hawkgs commented Mar 20, 2026

Should we add test-watch npm script to point to the potential contributors that this is available?

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds @bazel/ibazel as a dev dependency to the workspace root. The changes include modifications to package.json and pnpm-lock.yaml to include the new dependency and update related dependency versions.

"@babel/core": "7.29.0",
"@bazel/bazelisk": "1.28.1",
"@bazel/buildifier": "8.2.1",
"@bazel/ibazel": "^0.28.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding @bazel/ibazel as a dev dependency is a good practice for test-driven development and testing.

Comment on lines +73 to +75
'@bazel/ibazel':
specifier: ^0.28.0
version: 0.28.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding the @bazel/ibazel dependency to the pnpm-lock.yaml file ensures that the correct version is installed and used across different environments.

'@vitest/coverage-v8':
specifier: 4.1.0
version: 4.1.0(vitest@4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jiti@2.6.1)(jsdom@29.0.0)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2))
version: 4.1.0(vitest@4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jsdom@29.0.0)(vite@7.3.1(@types/node@24.12.0)(jiti@2.6.1)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the version of @vitest/coverage-v8 to include vite as a dependency ensures compatibility and proper functioning of the coverage tool.

vitest:
specifier: 4.1.0
version: 4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jiti@2.6.1)(jsdom@29.0.0)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2)
version: 4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jsdom@29.0.0)(vite@7.3.1(@types/node@24.12.0)(jiti@2.6.1)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the version of vitest to include vite as a dependency ensures compatibility and proper functioning of the testing framework.

vitest:
specifier: 4.1.0
version: 4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jiti@2.6.1)(jsdom@29.0.0)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2)
version: 4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jsdom@29.0.0)(vite@7.3.1(@types/node@24.12.0)(jiti@2.6.1)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the version of vitest to include vite as a dependency ensures compatibility and proper functioning of the testing framework.


'@bazel/buildifier@8.2.1': {}

'@bazel/ibazel@0.28.0': {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding @bazel/ibazel to the snapshots ensures that the lockfile accurately reflects the installed dependencies.

vite: 7.3.1(@types/node@24.12.0)(jiti@2.6.1)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2)

'@vitest/coverage-v8@4.1.0(vitest@4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jiti@2.6.1)(jsdom@29.0.0)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2))':
'@vitest/coverage-v8@4.1.0(vitest@4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jsdom@29.0.0)(vite@7.3.1(@types/node@24.12.0)(jiti@2.6.1)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2)))':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the version of @vitest/coverage-v8 to include vite as a dependency ensures compatibility and proper functioning of the coverage tool.

std-env: 4.0.0
tinyrainbow: 3.1.0
vitest: 4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jiti@2.6.1)(jsdom@29.0.0)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2)
vitest: 4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jsdom@29.0.0)(vite@7.3.1(@types/node@24.12.0)(jiti@2.6.1)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the version of vitest to include vite as a dependency ensures compatibility and proper functioning of the testing framework.

yaml: 2.8.2

vitest@4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jiti@2.6.1)(jsdom@29.0.0)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2):
vitest@4.1.0(@opentelemetry/api@1.9.0)(@types/node@24.12.0)(jsdom@29.0.0)(vite@7.3.1(@types/node@24.12.0)(jiti@2.6.1)(less@4.6.4)(sass@1.98.0)(terser@5.46.0)(tsx@4.21.0)(yaml@2.8.2)):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the version of vitest to include vite as a dependency ensures compatibility and proper functioning of the testing framework.

- jiti
- less
- lightningcss
- msw

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing transitive peer dependencies that are no longer needed simplifies the dependency graph and reduces potential conflicts.

@alan-agius4
Copy link
Collaborator

Should we add test-watch npm script to point to the potential contributors that this is available?

I don’t think that would too useful, as users would need to provide the test target, as it’s highly unlikely users would want to run all the tests in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants