fix(@angular/build): warn when vitest watch config conflicts with builder#32806
Merged
clydin merged 1 commit intoangular:mainfrom Mar 20, 2026
Merged
fix(@angular/build): warn when vitest watch config conflicts with builder#32806clydin merged 1 commit intoangular:mainfrom
clydin merged 1 commit intoangular:mainfrom
Conversation
…lder Added a warning in the `angular:vitest-configuration` plugin to alert users if the `watch` option specified in their `vitest.config.ts` differs from the Angular CLI builder's `--watch` option. Because the Angular CLI's build system and file watcher drives the execution, the Vitest-specific `watch` option is overridden and has no effect.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful warning for users when their vitest.config.ts watch setting conflicts with the Angular CLI's --watch option. The implementation correctly identifies the conflict, issues a warning, and overrides the configuration to prevent unexpected behavior. A corresponding test case has been added to ensure this functionality works as expected. I have one minor suggestion to improve the code's readability.
clydin
added
the
action: review
alan-agius4
approved these changes
Mar 20, 2026
alan-agius4
added
action: merge
1 task
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a warning in the
angular:vitest-configurationplugin to alert users if thewatchoption specified in theirvitest.config.tsdiffers from the Angular CLI builder's--watchoption. Because the Angular CLI's build system and file watcher drives the execution, the Vitest-specificwatchoption is overridden and has no effect.