feat(client): Rename ClientFactory to A2AClientFactory#886
feat(client): Rename ClientFactory to A2AClientFactory#886zeroasterisk wants to merge 1 commit intoa2aproject:1.0-devfrom
Conversation
…h for backwards compatibility
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the client factory implementation by renaming Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request renames ClientFactory to A2AClientFactory and provides a backward-compatibility alias. The changes are consistent across the codebase. My review includes one suggestion to add a TODO comment for future deprecation of the alias. Additionally, consider updating the tests in tests/client/test_client_factory.py to use the new A2AClientFactory name to align with the API changes.
| ) | ||
|
|
||
|
|
||
| ClientFactory = A2AClientFactory |
There was a problem hiding this comment.
While this alias is great for backward compatibility, it's a good practice to plan for its eventual deprecation to encourage users to adopt the new A2AClientFactory name. Adding a TODO comment here can help track this for the future.
| ClientFactory = A2AClientFactory | |
| ClientFactory = A2AClientFactory # TODO: Deprecate in favor of A2AClientFactory |
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/client/client_factory.py | 89.35% | 89.41% | 🟢 +0.06% |
| Total | 91.45% | 91.45% | ⚪️ 0.00% |
Generated by coverage-comment.yml
Completed task 555: Renamed
ClientFactorytoA2AClientFactoryfor backwards compatibility and spec alignment while auto-selecting transport based onsupportedInterfaces. Exported bothClientFactoryandA2AClientFactory.