CLI-179 add network test for install.sh script#121
CLI-179 add network test for install.sh script#121kirill-knize-sonarsource wants to merge 1 commit intomasterfrom
Conversation
SummaryAdds an integration test that validates the install.sh script works end-to-end, including downloading and executing the sonar CLI binary from binaries.sonarsource.com. The test verifies the binary installs to the correct location and runs successfully on the current platform. What reviewers should knowThis is a new network integration test in
|
kirill-knize-sonarsource
force-pushed
the
CLI-179
branch
from
c8fe9bb to
a907112
Compare
![sonar-review-alpha[bot]](https://avatars.githubusercontent.com/in/3025063?s=60&v=4){kind=small}
| () => { | ||
| const scriptPath = join(scriptDir, 'install.sh'); | ||
|
|
||
| const scriptContent = readFileSync(scriptPath, 'utf-8'); |
There was a problem hiding this comment.
The test downloads the exact version hardcoded in install.sh (version="0.6.1.603", line 76). If install.sh is ever bumped to a new version number before that version's artifacts are published to binaries.sonarsource.com, this test will fail in CI with a 404 or download error.
Is there a CI ordering guarantee that CDN publish always precedes an install.sh version bump landing on the main branch? If not, consider whether the test should skip or be tagged separately from the standard integration suite when run against an unreleased version.
- Mark as noise
kirill-knize-sonarsource
force-pushed
the
CLI-179
branch
from
a907112 to
aab8578
Compare
SonarQube reviewer guide
|
1 participant
No description provided.