CLI-77 Auto-install sonar-secrets during sonar integrate claude

[kirill-knize-sonarsource]

No description provided.

[sonar-review-alpha]

Summary

Removes the standalone sonar install secrets command and automatically installs sonar-secrets during sonar integrate claude. This simplifies the integration flow by making the tool installation an implicit part of the setup process rather than requiring a separate manual step.

What reviewers should know

Review focus: The core change is in src/cli/commands/integrate/claude/index.ts where performSecretInstall() is now called early in the integration workflow. The InstallSecretsOptions type and installSecrets() function still exist (in src/cli/commands/install/secrets.ts) but are no longer exposed as a CLI command—they're now only used internally. Tests have been updated to reflect this: the standalone install tests are deleted, and existing integrate tests now mock the binary as pre-installed. Two new test cases verify the auto-install behavior (downloads when missing, skips when already present). The imports in command-tree.ts have been simplified accordingly.

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[hashicorp-vault-sonar-prod]

CLI-77

[sonar-review-alpha]

Conclusion: Two real bugs introduced by the call to performSecretInstall in the integrate flow: an unhandled failure path that can block the entire integration, and a stale user-facing message that references a command that no longer exists.

🗣️ Give feedback

[sonar-review-alpha]

Conclusion

The auto-install idea is solid, but there are two bugs that need fixing before merge: a misleading phase label and several stale error messages pointing users to a command that no longer exists.

SonarCloud recommendations

None.

SonarCloud false positives

None.

🗣️ Give feedback

[sonar-review-alpha]

Conclusion

Three of the four previously flagged issues are now resolved, but the stale sonar install secrets references remain unfixed across both install/secrets.ts and analyze/secrets.ts.

🗣️ Give feedback

[sonarqubecloud]

SonarQube reviewer guide

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonar-review-alpha]

LGTM! ✅

🗣️ Give feedback