BUILD-10388 reactivate all tests#1651
Draft
julien-carsique-sonarsource wants to merge 2 commits intomasterfrom
Draft
BUILD-10388 reactivate all tests#1651julien-carsique-sonarsource wants to merge 2 commits intomasterfrom
julien-carsique-sonarsource wants to merge 2 commits intomasterfrom
Conversation
Base automatically changed from
feat/jcarsique/BUILD-10388-allInOneImage
to
master
February 27, 2026 10:14
This reverts commit 2d1c42f.
PyCharm 2025+ and all Rider versions do not display a Welcome Frame on startup, causing integration tests to fail with WaitForConditionTimeoutException. Changes: - Add getIdeVersionYear() helper to detect IDE version - Update openExistingProject() to handle: - PyCharm 2025+ (no welcome frame) - Rider (all versions, never had welcome frame) - GoLand 2025+ (already handled) - Use openFileSelector() workaround when Welcome Frame is not present This fixes 4 failing integration test jobs: - PC-2025.3.2.1 (PyCharm Community 2025) - PY-2025.3.2.1 (PyCharm Professional 2025) - RD-2023.1.7 (Rider 2023) - RD-2024.3.9 (Rider 2024) --- BUILD-10388 Fix compilation error: resolve isRider import conflict Fix duplicate import of isRider from two sources: - BaseUiTest.Companion.isRider (static function) - fixtures.isRider (extension function) Changes: - Import fixtures.isRider as isRiderExtension to avoid conflict - Use isRiderExtension() where calling extension function - Use isRider() where calling static function (in closeProject) - Import custom DialogFixture from fixtures package instead of RemoteRobot package This resolves the compilation error that broke all tests in run 22221651501. --- BUILD-10388 Fix dialog closing for PyCharm 2025+ and Rider Remove optionalStep wrapper from dialog closing code to allow exceptions to propagate and ensure dialogs are actually closed. optionalStep was silently swallowing exceptions, preventing proper error diagnosis. Also wrap dialog closing in idea{} block to ensure IDE is ready before attempting to find and close dialogs. This should fix IndexOutOfBoundsException when accessing File menu: - PC-2025.3.2.1 (PyCharmCommunity2025) - PY-2025.3.2.1 (PyCharmProfessional2025) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
julien-carsique-sonarsource
force-pushed
the
fix/jcarsique/BUILD-10388-allTests
branch
from
dfb292a to
694e9ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUILD-10388
Follow-up of #1640
Summary
Reactivates the 5 integration tests that were temporarily disabled in #1640 (BUILD-10388) and fixes the root cause of failures for PyCharm 2025+ and Rider.
Problem
PyCharm 2025+ and all Rider versions do not display a Welcome Frame on startup, causing integration tests to fail with
WaitForConditionTimeoutExceptionwhen the test framework waits for a frame that never appears.The following QA targets were disabled in #1640:
Changes
Fix: Welcome Frame handling for PyCharm 2025+ and Rider (
OpeningUtils.kt)getIdeVersionYear()helper inRemoteRobotExtensions.ktto detect the IDE version year from the build numberopenExistingProject()to skip waiting for the Welcome Frame when:openFileSelector()as the workaround when no Welcome Frame is presentidea{}block and removeoptionalStepto properly propagate exceptionsFix:
isRiderimport conflict (OpeningUtils.kt)fixtures.isRidertoisRiderExtensionto avoid ambiguity withBaseUiTest.Companion.isRiderisRiderExtension()for the extension function andisRider()for the static functionReactivate all 5 ITs (
.github/workflows/build.yml)Reverts the temporary disable introduced in BUILD-10388:
Note: RD-2025.1.5 remains disabled (pre-existing, unrelated issue).
Testing