NET-2922 Normalize NuSpec paths to Unix forward slash#9776
NET-2922 Normalize NuSpec paths to Unix forward slash#9776bdovaz wants to merge 2 commits intoSonarSource:masterfrom
Conversation
|
Hi, I understand that Unix systems are generally not capable of understanding paths written by Windows, as it only work the other way around. We should be able to update that. What is not clear to me is where the change happened. When I look at the nuspec file from the commit, I see all old paths (like At the same time, while the documentation seems to refer it to it as "path" everywhere, without explicit separator rules, all the examples are using windows Can you share what are the commands or tools that you're using to reproduce the issue? |
pavel-mikula-sonarsource
left a comment
There was a problem hiding this comment.
Just a consistency check for now
|
@pavel-mikula-sonarsource Ready to review. And regarding your questions, everything comes from here: sensslen/nuget-license#290 But it can potentially be affected by other tools, so it's better to use |
|
Internal ticket: NET-2922 |
|
The change looks good, but I can't merge it just yet. I'll need to run this through internal QA CI and do also some manual testing, as we don't have enough QA for NuGet packages themselves. Due to holiday season etc, I'll come back to this by the end of January. |
In this commit 5a23948#diff-f8f453a6bb79d1bba0a5f48cfd1d9a73373d4e68008591548d15bb0ef30abaa4R9 I see that the path has been changed, but it has been changed to a Windows path and not a normalized one that any OS can interpret.
This is starting to cause problems when you try to read the package metadata (license in this case) through dotnet tooling or NuGet packages with their API when doing so from a Linux machine.