BUILD-10761: Fix credential guard SQ Analysis security hotspot

[bwalsh434]

Problem

All recent ~5 recent commits on master have been failing the SonarCloud Code Analysis check due to Security Hotspots, see screenshot below and link to hotspots.

What Changed?

• This PR fixes the credential guard SQ Analysis security hotspot relating to tmp dir creds file for the credential guard check

[sonarqube-cloud-us]

SonarQube reviewer guide

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

SonarQube reviewer guide

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonar-review-alpha]

Summary

Fixes a SonarQube security hotspot by replacing hardcoded /tmp/ path with os.tmpdir() in the credential guard test. This ensures the temporary directory path is properly resolved based on the system environment rather than using an absolute path, improving portability and security.

What reviewers should know

The change is minimal and localized to one test file. Review focuses on: (1) confirm path.join() and os.tmpdir() are the standard Node.js way to construct temp paths portably, (2) verify the test behavior is unchanged—it still validates that core.saveState() is called with the correct credentials file path, and (3) ensure this matches the same pattern used in the actual credential-guard-main source code (not just the test).

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[sonar-review-alpha]

Conclusion: Minimal, correct fix. The hardcoded /tmp literal in the test is replaced with os.tmpdir() — the right approach for platform-portable temp path construction, and the proper way to resolve this class of SonarQube hotspot. The test behavior is identical; only the path construction changes.

🗣️ Give feedback