JS-776 Remove in-rule React detection and rely on requiredDependency

[zglicz]

Summary

• remove per-rule React detection logic (detectReactRule) from S6440 and S6441
• remove redundant react dependency guards from S6477 and S6747
• delete unused rule-detect-react helper
• keep fixtures focused on React scenarios only
• add linter tests verifying requiredDependency filtering for a React rule (disabled without react, enabled with react)

Validation

• npx tsx --tsconfig packages/tsconfig.test.json --test packages/jsts/src/rules/S6440/cb.test.ts packages/jsts/src/rules/S6441/cb.test.ts packages/jsts/tests/linter/index.test.ts

[hashicorp-vault-sonar-prod]

JS-776

[github-actions]

Ruling Report

New issues flagged (9 issues)

S6440

eigen/src/app/Components/ArtworkGrids/LotCloseInfo.tsx:30

    28 |     return null
    29 |   }
>   30 |   const { hasEnded: lotHasClosed } = useTimer(lotEndAt, sale.startAt ?? "")
    31 | 
    32 |   const { hasEnded: lotsAreClosing, hasStarted: saleHasStarted } = useTimer(

eigen/src/app/Components/ArtworkGrids/LotCloseInfo.tsx:32

    30 |   const { hasEnded: lotHasClosed } = useTimer(lotEndAt, sale.startAt ?? "")
    31 | 
>   32 |   const { hasEnded: lotsAreClosing, hasStarted: saleHasStarted } = useTimer(
    33 |     sale.endAt!,
    34 |     sale.startAt!

eigen/src/app/Scenes/Inbox/Components/Conversations/OpenInquiryModalButton.tests.tsx:14

    12 | import { OpenInquiryModalButtonFragmentContainer } from "./OpenInquiryModalButton"
    13 | 
>   14 | const trackEvent = useTracking().trackEvent
    15 | 
    16 | jest.unmock("react-relay")

eigen/src/app/utils/platformUtil.ts:10

     8 |     return 0
     9 |   } else {
>   10 |     return 13 + useSafeAreaInsets().top
    11 |   }
    12 | }

moose/renderer/utils/animations.ts:29

    27 | 
    28 |   const translateY = `${reverse ? -5 : 5}px`;
>   29 |   return useTransition(item, keys, {
    30 |     from: {
    31 |       opacity: 0,

moose/renderer/utils/animations.ts:48

    46 | 
    47 | export function fadeIn(item, keys) {
>   48 |   return useTransition(item, keys, {
    49 |     from: {
    50 |       opacity: 0,

moose/renderer/utils/animations.ts:65

    63 | 
    64 | export function scale(item) {
>   65 |   return useTransition(item, null, {
    66 |     from: { transform: "scale(0.5)", opacity: 0 },
    67 |     enter: { transform: "scale(1)", opacity: 1 },

sonar-web/src/main/js/helpers/measures.js:12

    10 | export function formatMeasure (value, type) {
    11 |   let formatter = getFormatter(type);
>   12 |   return useFormatter(value, formatter);
    13 | }
    14 | 

sonar-web/src/main/js/helpers/measures.js:23

    21 | export function formatMeasureVariation (value, type) {
    22 |   let formatter = getVariationFormatter(type);
>   23 |   return useFormatter(value, formatter);
    24 | }
    25 | 

[sonar-review-alpha]

Generating a summary...

[zglicz]

Here we override the builtin messages from eslint

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[vdiez]

this needs to be more exhaustive, there are more rules trying to detect react aside of the rule-detect-react.ts helper. some are using custom esquery selectors. check S6439 or S6443 for example.

[zglicz]

Both of those rule can't immediately benefit from simplification.

• S6439 - additionaly checks if react-native is present and has a little bit different logic
• S6443 - checks fqn to make sure its a react hook call

I did update rspec with required dependencies for a few of these rules - https://github.com/SonarSource/rspec/pull/6379