Conversation
Refactor/styles separate css
There was a problem hiding this comment.
Pull request overview
Updates the light theme design-token set by introducing additional CSS custom properties for borders, spacing, sizing, shadows, overlays, opacity, and layout.
Changes:
- Added new border-related tokens (accent border color, additional border widths, additional border radii).
- Expanded spacing tokens (very small spacings and a button-specific spacing token).
- Added additional shadow, overlay, opacity, and layout tokens.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --color-text-brown: #440; | ||
|
|
||
| /* Borders */ | ||
| --color-border: #ccc; | ||
| --color-border-dark: #777; | ||
| --color-border-darker: #444; | ||
| --color-border-light: #aaa; | ||
| --color-border-pale: #eee; |
There was a problem hiding this comment.
These new theme tokens (e.g., --color-border-accent) are only defined in the light theme. src/styles/themes/dark.css does not currently define them, so if/when dark mode is enabled they will fall back to the light values and can cause inconsistent/low-contrast UI. Add matching variables (with dark-appropriate values) to dark.css to keep the theme contract consistent.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@timea-solid I've opened a new pull request, #344, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: timea-solid <4144203+timea-solid@users.noreply.github.com> Agent-Logs-Url: https://github.com/SolidOS/mashlib/sessions/fc474993-e7a9-44a2-8238-ad3361eb9c58
Mirror new CSS tokens from light.css into dark.css
…into profileEditA11y
Some new variables from profile pane and others were added to mashlib.