Fix schedule pane not being displayed in the folder view.#167
Open
SharonStrats wants to merge 4 commits intorefactor/styles-separateCSSfrom
Open
Fix schedule pane not being displayed in the folder view.#167SharonStrats wants to merge 4 commits intorefactor/styles-separateCSSfrom
SharonStrats wants to merge 4 commits intorefactor/styles-separateCSSfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the folder pane’s “package view” detection so folders that don’t have index.ttl#this but do have legacy schedule-pane data in details.ttl#event can still render the intended pane view rather than falling back to a raw container listing.
Changes:
- Detect
details.ttl(viadetails.ttl#event) as a fallback “view subject” whenindex.ttlis not present. - Load and render the chosen view document/subject via the outliner.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+103
to
106
| const sourceLabel = hasIndexDoc ? 'index' : 'details-fallback' | ||
| console.log( | ||
| 'View of folder will be view of indexThing. Loading ' + indexThing | ||
| '[folder-pane] using ' + sourceLabel + ' view subject: ' + folderViewThing | ||
| ) |
There was a problem hiding this comment.
This console.log runs on every render when index.ttl or details.ttl is present, which can be noisy in production and makes it harder to debug other issues. Consider removing it or gating it behind an explicit debug flag/logging facility so normal folder navigation doesn’t spam the console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket SolidOS/solid-panes#180
folder-pane hardcodes index.ttl#this for rendering and looking through label on the panes, but the data for schedulePane is stored at details.ttl#event. In order to render old schedulePanes this needs to be done. However in the future we should modify schedulePanes to create an index.ttl#this defining it's type.