Add test cases and emulator testing in CI#39
Merged
colemancda merged 20 commits intoPureSwift:masterfrom Mar 25, 2026
Merged
Conversation
…o use the swift-android-native accessor
Contributor
Author
|
Ready for review, @colemancda |
colemancda
approved these changes
Mar 25, 2026
Member
|
@marcprux I think adding convenience accessors for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a single test case and augments the GitHub CI workflow to invoke the new
skip android test --apkflag to perform emulator testing with the library embedded with an .apk file (which enables calling Java functions).In the test case we add a accessor for
AndroidApp.Application.currentApplication(), which uses theswift-android-nativelow-levelAndroidContext.applicationcontext accessor (added in swift-android-sdk/swift-android-native#6) and wraps it in the swift-java-bridgedAndroidApp.Application. The test case then performs some rudimentary testing on it.An open question is whether to promote these accessor extensions to the corresponding
AndroidApp.ApplicationandAndroidContent.Contextpackages, or if there is some other preferred way of doing this.