Dynamically hydrate contributors list#21
Open
Anne-Flower wants to merge 3 commits intoNodeSecure:mainfrom
Open
Dynamically hydrate contributors list#21Anne-Flower wants to merge 3 commits intoNodeSecure:mainfrom
Anne-Flower wants to merge 3 commits intoNodeSecure:mainfrom
Conversation
fraxken
reviewed
Mar 21, 2026
fraxken
reviewed
Mar 21, 2026
Comment on lines
+19
to
+28
| const coreContributors = [ | ||
| "fraxken", | ||
| "PierreDemailly", | ||
| "tony-go", | ||
| "antoine-coulon", | ||
| "Kawacrepe", | ||
| "im-codebreaker", | ||
| "clemgbld", | ||
| "fabnguess" | ||
| ]; |
Member
There was a problem hiding this comment.
Would be good to continue to fetch them from the list in the governance repo like the old code
const response = await fetch("https://raw.githubusercontent.com/NodeSecure/Governance/main/contributors.json");
So if we update the JSON there, this script fetch the right members of the core team
PierreDemailly
approved these changes
Mar 21, 2026
clemgbld
reviewed
Mar 21, 2026
|
|
||
| const uniqueContributors = new Map(); | ||
| for (const contributor of contributors) { | ||
| if (bots.includes(contributor.login)) { |
Member
There was a problem hiding this comment.
Suggested change
| if (bots.includes(contributor.login)) { | |
| if (bots.includes(contributor.login) || uniqueContributors.has(contributor.login)) { |
And you can remove the nested if just below it would be a bit more readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.