Skip to content

feat: generate open api types through remote assets#84

Merged
Alessandro100 merged 1 commit intomainfrom
feat/generate-types-through-assets
Mar 24, 2026
Merged

feat: generate open api types through remote assets#84
Alessandro100 merged 1 commit intomainfrom
feat/generate-types-through-assets

Conversation

@Alessandro100
Copy link
Contributor

Summary:

closes #33

To generate api types this repo will now fetch the latest version coming from the mobility feeds api repo. Meaning it will only fetch the types that have been published to production

Expected behavior:

When running the command yarn generate:api-types it should fetch the DatabaseCatalogAPI.yaml file from the mobility-feeds-api repo and generate the typescript types to use

Testing tips:

  1. Delete or modify the file src/app/services/feeds/types.ts
  2. Run the command yarn generate:api-types
  3. See that there are no git changes due to the types.ts file being the same

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with yarn test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mobilitydatabase-web Ready Ready Preview, Comment Mar 24, 2026 3:28pm

Request Review

@github-actions
Copy link

*Lighthouse ran on https://mobilitydatabase-4eetx7atf-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 89 🟢 96 🟢 100 🟢 100

*Lighthouse ran on https://mobilitydatabase-4eetx7atf-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 87 🟠 87 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-4eetx7atf-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🔴 41 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-4eetx7atf-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 69 🟠 83 🟢 100 🟢 100

*Lighthouse ran on https://mobilitydatabase-4eetx7atf-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 91 🟢 94 🟢 96 🟢 100

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alessandro100 Alessandro100 merged commit 5a41671 into main Mar 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSR: Generate Types through asset

2 participants