MDEV-39126: Feedback plugin to use /etc/os-release#4829
Open
itzanway wants to merge 2 commits intoMariaDB:10.11from
Open
MDEV-39126: Feedback plugin to use /etc/os-release#4829itzanway wants to merge 2 commits intoMariaDB:10.11from
itzanway wants to merge 2 commits intoMariaDB:10.11from
Conversation
ff55a8a to
363c513
Compare
gkodinov
requested changes
Mar 23, 2026
Member
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
First of all: please squash your two commits into a single one and add a commit message that's complaint to MariaDB condig standards (you can find the .md file with these in the repository).
Secondly (and optionally, at least for the preliminary review): would you please consider implementing a test for this?
I'd give it a day or two and go about it by checking in mtr if I'm running on a suitable platform (otherwise skip). Then I'd inspect the contents of the https://mariadb.com/docs/server/reference/system-tables/information-schema/information-schema-tables/information-schema-feedback-table and try to find the info from os_release there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves MDEV-39126 by updating the feedback plugin to use
/etc/os-releaseinstead of the obsolete/etc/lsb-releasefor OS discovery.As noted in the issue,
/etc/lsb-releaseis outdated (Debian now isolates it to its own package), while/etc/os-releaseis the modern, portable standard across Linux distributions.Implementation Details
prepare_linux_info()inplugin/feedback/utils.ccto attempt opening/etc/os-releasefirst.PRETTY_NAME=field and safely strip the wrapping double quotes to extract a clean, human-readable distribution name./etc/os-release, the original/etc/lsb-releaseand wildcard mask (/etc/*-release) checks have been retained as fallbacks.Testing