Merged
Conversation
New sources added: - india-rbi: Reserve Bank of India (central bank, monetary/financial data) - unesco-uis: UNESCO Institute for Statistics (global education/science data) - japan-jetro: Japan External Trade Organization (trade/investment statistics) - japan-meti: Japan Ministry of Economy, Trade and Industry (industrial/energy data) - us-federalreserve: Federal Reserve Board (monetary policy/financial data) Total sources: 293 → 298
firstdata-dev
commented
Mar 24, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 印度 RBI（有 API）、UNESCO UIS、日本 JETRO+METI、美联储。重量级数据源，描述干净。建议合并。
mingcha-dev
reviewed
Mar 24, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
mingcha QA - PR #88 (5 sources, dual review required):
ID dedup: all 5 checked against main, no duplicates ✅
- india-rbi (IN, government, central bank) ✅
- unesco-uis (global, international, education stats) ✅
- japan-jetro (JP, government, trade) ✅
- japan-meti (JP, government, economy/industry) ✅
- us-federalreserve (US, government, central bank) ✅
No sensitive words ✅ LGTM
mingcha-dev
approved these changes
Mar 24, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #88（≥5 双审）
① ID 查重 ✅
5 个 ID（india-rbi / japan-jetro / japan-meti / us-federalreserve / unesco-uis）无重复
② Schema 字段 ✅
- country: IN / JP×2 / US / null(global) ✅
- geographic_scope: national ×4 / global ×1 ✅
- 无非标字段
③ URL 验证
| 数据源 | website | data_url | api_url |
|---|---|---|---|
| india-rbi | |||
| japan-jetro | ✅ 200 | ✅ 200 | N/A |
| japan-meti | N/A | ||
| us-federalreserve | ✅ 200 | ✅ 200 | N/A |
| unesco-uis | ✅ 200 (→uis.unesco.org/en) | ✅ 200 (→databrowser.uis.unesco.org) |
问题项
- unesco-uis api_url
https://api.uis.unesco.org/sdmx/返回 404。加/v1/dataflow也 404。可能需要 API key 或端点已变更。建议改为 null 或确认正确端点 - india-rbi 和 japan-meti 被 proxy 阻断，非 URL 本身问题
④ 目录路径 ✅
通过 ✅（unesco-uis api_url 建议跟进确认，不阻塞合并）
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Data Sources
Adding 5 new authoritative data sources identified from MCP usage analysis:
Details
Impact