feat: Added classic snap packaging#294
Open
kenvandine wants to merge 1 commit intoFrameworkComputer:mainfrom
Open
feat: Added classic snap packaging#294kenvandine wants to merge 1 commit intoFrameworkComputer:mainfrom
kenvandine wants to merge 1 commit intoFrameworkComputer:mainfrom
Conversation
Member
|
Cool I tried it and it can work locally |
| "${CRAFT_PART_INSTALL}/share/fish/vendor_completions.d/framework_tool.fish" | ||
|
|
||
| apps: | ||
| framework-tool: |
Member
There was a problem hiding this comment.
that changes the executable name to hyphen instead of underscore?
Author
There was a problem hiding this comment.
The snap name/app-name doesn't allow underscores as it means something different to snapd. Snaps can have different versions installed in parallel, and that "instances" are determined with an underscore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at creating a classic snap. It's possible this could be done with strict confinement, we would need to do some investigation to see if there are interfaces to everything required.