fix joins for missing key columns#187
Open
Anamika1608 wants to merge 7 commits intoDataHaskell:mainfrom
Open
Conversation
Contributor
Author
|
@daikonradish @mchav, can you review this pr? |
mchav
requested changes
Mar 20, 2026
Contributor
|
We've left some comments, but in general your code looks good. Some of it is very stylish! Thank you for your effort. |
Contributor
Author
|
@mchav @daikonradish fixed all the issues. check once? |
mchav
requested changes
Mar 21, 2026
| import Type.Reflection | ||
| import Prelude hiding (filter, take) | ||
|
|
||
| #if MIN_VERSION_random(1,3,0) |
Member
There was a problem hiding this comment.
Does this prevent compilation? What ghc and build tool are you using?
Contributor
Author
There was a problem hiding this comment.
no for the repo’s normal build. this module enables CPP, and MIN_VERSION_random(...) is provided by cabal preprocessing. i tested it with ghc 9.10.3 and cabal-install 3.16.1.0 in the nix dev shell, and the repo ci also builds with cabal. if someone compiles the file with bare ghc outside cabal, then that macro would not be defined.
Contributor
Author
|
@mchav check now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #118
summary
this fixes the join behavior when a requested join key does not exist. instead of silently hashing an empty key set and producing cartesian style output, joins now fail fast with the existing columnnotfoundexception.
what changed
behavior
before this change, a missing join column could fall through to hashing zero key columns, which made every row hash the same and could expand into cartesian style output. after this change, the join fails immediately with the missing column name and the existing available column context.
verification