[PWGHF] Add histograms in Non-HFE analysis#15491
Open
rashigupt wants to merge 2 commits intoAliceO2Group:masterfrom
Open
[PWGHF] Add histograms in Non-HFE analysis#15491rashigupt wants to merge 2 commits intoAliceO2Group:masterfrom
rashigupt wants to merge 2 commits intoAliceO2Group:masterfrom
Conversation
rashigupt
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
bot
changed the title
Collaborator
|
Your branch is very outdated. Please update it, test everything, and push the update to your remote branch. |
Collaborator
|
You didn't have to close the PR. You just need to update your branch. |
Contributor
Author
|
okay Thankyou @vkucera |
Contributor
Author
|
Dear expert, if everything looks fine, kindly approve and merge the code. |
apalasciano
requested changes
Mar 24, 2026
Collaborator
apalasciano
left a comment
apalasciano
left a comment
There was a problem hiding this comment.
Hello @rashigupt,
I have comments on a few of the if conditions you just added.
| if (!isEMcal) { | ||
| registry.fill(HIST("hLikeMass_EMCAL"), massLike); | ||
| } else { | ||
| registry.fill(HIST("hLikeMass_NoEMCAL"), massLike); |
Collaborator
There was a problem hiding this comment.
This can be a source of confusion.
For example:
If isEMcal==TRUE you fill hLikeMass_NoEMCAL
If isEMcal==FALSE you fill hLikeMass_EMCAL
Shouldn't the if condition be the opposite?
| if (!isEMcal) { | ||
| registry.fill(HIST("hUnLikeMass_EMCAL"), massUnLike); | ||
| } else { | ||
| registry.fill(HIST("hUnLikeMass_NoEMCAL"), massUnLike); |
Contributor
Author
There was a problem hiding this comment.
okay Thankyou @apalasciano , I will correct it accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional histograms in the Non-HFE analysis to store Non-HFE electron information in the electronSelectionWithTPCEMCal task.