Skip to content

Add missing track->resetCov before refit for revertexing #15219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shahor02 wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −4
Open

Add missing track->resetCov before refit for revertexing #15219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Detectors/GlobalTrackingWorkflow/study/src/CheckResid.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ bool CheckResidSpec::processITSTrack(const o2::its::TrackITS& iTrack, const o2::
auto inv2d = [](float s00, float s11, float s01) -> std::array<float, 3> {
auto det = s00 * s11 - s01 * s01;
if (det < 1e-16) {
LOGP(error, "Singular det {}, input: {} {} {}", det, s00, s11, s01);
return {0.f, 0.f, 0.f};
}
det = 1.f / det;
Expand All @@ -329,11 +330,11 @@ bool CheckResidSpec::processITSTrack(const o2::its::TrackITS& iTrack, const o2::
LOGP(debug, "Failed to propagateToDCA, {}", trFitOut.asString());
return false;
}
float cosAlp, sinAlp;
pvAlpha = trFitOut.getAlpha();
o2::math_utils::sincos(trFitOut.getAlpha(), sinAlp, cosAlp); // vertex position rotated to track frame
o2::BaseCluster<float> bcPV;
if (params.addPVAsCluster) {
float cosAlp, sinAlp;
pvAlpha = trFitOut.getAlpha();
o2::math_utils::sincos(trFitOut.getAlpha(), sinAlp, cosAlp); // vertex position rotated to track frame
bcPV.setXYZ(pv.getX() * cosAlp + pv.getY() * sinAlp, -pv.getX() * sinAlp + pv.getY() * cosAlp, pv.getZ());
bcPV.setSigmaY2(0.5 * (pv.getSigmaX2() + pv.getSigmaY2()));
bcPV.setSigmaZ2(pv.getSigmaZ2());
Expand Down Expand Up @@ -400,7 +401,7 @@ bool CheckResidSpec::processITSTrack(const o2::its::TrackITS& iTrack, const o2::
auto wInw = inv2d(tInw.getSigmaY2(), tInw.getSigmaZ2(), tInw.getSigmaZY());
auto wOut = inv2d(tOut.getSigmaY2(), tOut.getSigmaZ2(), tOut.getSigmaZY());
if (wInw[0] == 0.f || wOut[0] == 0.f) {
return -1;
return false;
}
std::array<float, 3> wTot = {wInw[0] + wOut[0], wInw[1] + wOut[1], wInw[2] + wOut[2]};
auto cTot = inv2d(wTot[0], wTot[1], wTot[2]);
Expand Down Expand Up @@ -481,6 +482,8 @@ bool CheckResidSpec::refitITStrack(o2::track::TrackParCov& track, GTrackID gid)
const auto& params = CheckResidConfig::Instance();
auto pid = track.getPID();
track = trkITS.getParamOut();
track.resetCovariance();
track.setCov(track.getQ2Pt() * track.getQ2Pt() * track.getCov()[14], 14);
track.setPID(pid);
auto nCl = trkITS.getNumberOfClusters();
auto geom = o2::its::GeometryTGeo::Instance();
Expand Down
Loading